Update openmp/offload to new LLVM-22 build setup #152011
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZuseZ4
added
T-bootstrap
rustbot
added
the
S-waiting-on-author
jhuber6
reviewed
Feb 2, 2026
| .profile(profile) | ||
| .env("LLVM_CONFIG_REAL", &host_llvm_config) | ||
| .define("LLVM_ENABLE_ASSERTIONS", "ON") | ||
| .define("LLVM_ENABLE_RUNTIMES", "openmp;offload") |
There was a problem hiding this comment.
offload won't work targeting a GPU. I made a change to silently accept this upstream but I don't think you're on that.
Member
Author
There was a problem hiding this comment.
I tried it, but I don't think it's worth backporting. Fwiw this config works locally without your LLVM PR.
ZuseZ4
commented
Feb 3, 2026
rustbot
added
the
A-LLVM
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
update-offload-bootstrap
branch
from
1a6f0e4 to
a85f0aa
Compare
Contributor
|
☔ The latest upstream changes (presumably #152213) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just testing the libc-gpu build as well, will push an update later.
cc @jhuber6 Does that look like what you have in mind? I'm running all 3 reusing the same output directory (out_dir). I know I shouldn't do that for higher level differences like llvm vs omp/offload builds, but when just having different targets it seems to work fine (?)
cc @Sa4dUs can you test this please for nvidia?
blocked-on LLVM rc3, which should include: llvm/llvm-project#179375